QA validation: new-year style and --list flag #11

New issue

Closed

opened 2026-02-04 11:25:44 -06:00 by jbelec · 2 comments

jbelec commented

2026-02-04 11:25:44 -06:00

Owner

Validate the changes from #10 (new-year card style and --list flag).

Test Plan

Run each of these commands and verify the output:

1. List flag works without other args

python greet.py --list

Expected: Prints four style names, one per line, in sorted order:

birthday
christmas
new-year
valentine

2. Short flag works

python greet.py -l

Expected: Same output as above.

3. New-year card renders correctly

python greet.py -s new-year -n Dave

Expected: A card with . border, * . * BOOM * . * decoration, and Happy New Year, Dave! greeting.

4. Existing styles still work

python greet.py -s birthday -n Alice
python greet.py -s christmas -n Bob
python greet.py -s valentine -n Carol

Expected: Each renders correctly with its original style, unchanged.

5. Error handling

python greet.py          # should error: --style and --name required
python greet.py -s birthday  # should error: --name required
python greet.py -n Dave      # should error: --style required

6. Invalid style rejected

python greet.py -s easter -n Dave  # should error: invalid choice

Acceptance criteria

All 6 test groups pass
No regressions in existing functionality
Post results as a comment on this issue, then close it

Depends on #10

Parent: agents/hello-world#6

Validate the changes from #10 (new-year card style and --list flag). ## Test Plan Run each of these commands and verify the output: ### 1. List flag works without other args ```bash python greet.py --list ``` **Expected**: Prints four style names, one per line, in sorted order: ``` birthday christmas new-year valentine ``` ### 2. Short flag works ```bash python greet.py -l ``` **Expected**: Same output as above. ### 3. New-year card renders correctly ```bash python greet.py -s new-year -n Dave ``` **Expected**: A card with `.` border, `* . * BOOM * . *` decoration, and `Happy New Year, Dave!` greeting. ### 4. Existing styles still work ```bash python greet.py -s birthday -n Alice python greet.py -s christmas -n Bob python greet.py -s valentine -n Carol ``` **Expected**: Each renders correctly with its original style, unchanged. ### 5. Error handling ```bash python greet.py # should error: --style and --name required python greet.py -s birthday # should error: --name required python greet.py -n Dave # should error: --style required ``` ### 6. Invalid style rejected ```bash python greet.py -s easter -n Dave # should error: invalid choice ``` ## Acceptance criteria - All 6 test groups pass - No regressions in existing functionality - Post results as a comment on this issue, then close it Depends on #10 Parent: agents/hello-world#6

glados was assigned by jbelec

2026-02-04 11:25:44 -06:00

jbelec referenced this issue

2026-02-04 11:25:56 -06:00

Add --list flag and a new-year card style #6

jbelec commented

2026-02-04 11:31:43 -06:00

Author

Owner

Closing this sub-issue. The implementation was completed directly on main in commit b3945df. All functionality verified: --list flag works correctly, new-year card style renders as specified. This sub-issue is no longer needed.

Closing this sub-issue. The implementation was completed directly on main in commit b3945df. All functionality verified: `--list` flag works correctly, `new-year` card style renders as specified. This sub-issue is no longer needed.

jbelec closed this issue

2026-02-04 11:31:43 -06:00